New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted test according to feedback (#14783) #14833

Merged

ruudboon merged 1 commit into phalcon:4.0.x from ruudboon:fixes/issue-14783

Feb 10, 2020

Member

ruudboon commented Feb 10, 2020

…con/issues/14783#issuecomment-583866414)

Hello!

Type: code quality
Link to issue: [BUG]: Segmentation Fault Resultset/Complex, keepSnapshots=true #14783

In raising this pull request, I confirm the following:

I have read and understood the Contributing Guidelines
I have checked that another pull request for this purpose does not exist
I wrote some tests for this PR
I have updated the relevant CHANGELOG
I have created a PR for the documentation about this change

Adjusted tests to approach examples of issue


          Adjusted test according to feedback (#14783 (comment))

f06addf

ruudboon changed the base branch from master to 4.0.x

February 10, 2020 14:17

Jeckerson approved these changes

View reviewed changes

ruudboon merged commit d8eec77 into phalcon:4.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet