Skip to content

Fix memory leak in Micro #16404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Fix memory leak in Micro #16404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05589ec
Remove set of 'application' service
Jeckerson Aug 15, 2023
3fc5700
Remove redundant tests
Jeckerson Aug 15, 2023
cf60c93
Fix typo
Jeckerson Aug 15, 2023
c2ddce6
Update changelog
Jeckerson Aug 15, 2023
3532098
Change next version to `5.3.0`
Jeckerson Aug 15, 2023
60d0829
Change next version to `5.3.0`
Jeckerson Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions CHANGELOG-5.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
# Changelog

## [5.2.4](https://github.com/phalcon/cphalcon/releases/tag/v5.2.4) (xxxx-xx-xx)
## [5.3.0](https://github.com/phalcon/cphalcon/releases/tag/v5.3.0) (xxxx-xx-xx)

### Added
- Added `Phalcon\Mvc\Model::appendMessagedFrom` for code consistency and to add messages from another another model. [#16391](https://github.com/phalcon/cphalcon/issues/16391)

- Added `Phalcon\Mvc\Model::appendMessagedFrom` for code consistency and to add messages from another model [#16391](https://github.com/phalcon/cphalcon/issues/16391)
- Added `Phalcon\Autoload\Loader::isRegistered` for debugging purposes [#16391](https://github.com/phalcon/cphalcon/issues/16391)
- Added `Phalcon\Mvc\Model\Metadata::initializeMetadata` [#16393] (https://github.com/phalcon/cphalcon/issues/16393)
- Added `Phalcon\Mvc\Model\Metadata::getMetaDataUniqueKey` [#16393] (https://github.com/phalcon/cphalcon/issues/16393)
- Added `Phalcon\Mvc\Model\Metadata::getColumnMapUniqueKey` [#16393] (https://github.com/phalcon/cphalcon/issues/16393)
- Added `Phalcon\Encryption\Security\JWT\Builder::addHeader()` to allow adding custom headers [#16396](https://github.com/phalcon/cphalcon/issues/16396)

### Changed
- Refactored `Phalcon\Mvc\Model::doLowUpdate` and `Phalcon\Mvc\Model::postSaveRelatedRecords` for better code logic and a clearer seperation of behaviour although it lead to partially repeated code.[#16391](https://github.com/phalcon/cphalcon/issues/16391)

- Refactored `Phalcon\Mvc\Model::doLowUpdate` and `Phalcon\Mvc\Model::postSaveRelatedRecords` for better code logic and a clearer separation of behaviour, although it lead to partially repeated code. [#16391](https://github.com/phalcon/cphalcon/issues/16391)
- Cleaned `Phalcon\Mvc\Model\Metadata::initialize` [#16393] (https://github.com/phalcon/cphalcon/issues/16393)

### Fixed

- Parse multipart/form-data from PUT request [#16271](https://github.com/phalcon/cphalcon/issues/16271)
- Set Dynamic Update by default system wide [#16343](https://github.com/phalcon/cphalcon/issues/16343)

### Added

- Added `Phalcon\Encryption\Security\JWT\Builder::addHeader()` to allow adding custom headers [#16396](https://github.com/phalcon/cphalcon/issues/16396)
- Set Dynamic Update by default system-wide [#16343](https://github.com/phalcon/cphalcon/issues/16343)
- Fixed memory leak in Micro application [#16404](https://github.com/phalcon/cphalcon/pull/16404)


## [5.2.3](https://github.com/phalcon/cphalcon/releases/tag/v5.2.3) (2023-07-26)
Expand Down
7 changes: 0 additions & 7 deletions phalcon/Mvc/Micro.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,13 +1142,6 @@ class Micro extends Injectable implements ArrayAccess, EventsAwareInterface
*/
public function setDI(<DiInterface> container) -> void
{
/**
* We automatically set ourselves as application service
*/
if !container->has("application") {
container->set("application", this);
}

let this->container = container;
}

Expand Down
8 changes: 0 additions & 8 deletions tests/integration/Mvc/Micro/HasServiceCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,14 @@ public function mvcMicroHasService(IntegrationTester $I)
$I->wantToTest('Mvc\Micro - hasService()');

$micro = new Micro();

$di = new Di();

$micro->setDi($di);


$I->assertFalse(
$micro->hasService('fake')
);

$I->assertTrue(
$micro->hasService('application')
);

$I->assertFalse(
$micro->hasService('escaper')
);
Expand All @@ -57,7 +51,6 @@ public function mvcMicroHasService(IntegrationTester $I)


$escaper = new Escaper();

$micro->setService('escaper', $escaper);

$I->assertTrue(
Expand All @@ -75,7 +68,6 @@ public function mvcMicroHasService(IntegrationTester $I)


$router = new Router();

$di->set('router', $router);

$I->assertTrue(
Expand Down
11 changes: 0 additions & 11 deletions tests/integration/Mvc/Micro/OffsetExistsCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,14 @@ public function mvcMicroOffsetExists(IntegrationTester $I)
$I->wantToTest('Mvc\Micro - offsetExists()');

$micro = new Micro();

$di = new Di();

$micro->setDi($di);


$I->assertFalse(
isset($micro['fake'])
);

$I->assertTrue(
isset($micro['application'])
);

$I->assertFalse(
isset($micro['escaper'])
);
Expand All @@ -57,25 +51,20 @@ public function mvcMicroOffsetExists(IntegrationTester $I)


$escaper = new Escaper();

$micro->setService('escaper', $escaper);

$I->assertTrue(
isset($micro['escaper'])
);


$dispatcher = new Dispatcher();

$micro['dispatcher'] = $dispatcher;

$I->assertTrue(
isset($micro['dispatcher'])
);


$router = new Router();

$di->set('router', $router);

$I->assertTrue(
Expand Down