Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSqlExpression() should not be final #3026

Merged
merged 1 commit into from
Nov 13, 2014
Merged

getSqlExpression() should not be final #3026

merged 1 commit into from
Nov 13, 2014

Conversation

dugwood
Copy link
Contributor

@dugwood dugwood commented Nov 13, 2014

If we need to extend the dialect, we have to overload the getSqlExpression(). See #2952 and http://forum.phalconphp.com/discussion/1748/date-sub-interval-mysql

If we need to extend the dialect, we have to overload the getSqlExpression(). See #2952 and http://forum.phalconphp.com/discussion/1748/date-sub-interval-mysql
@dugwood
Copy link
Contributor Author

dugwood commented Nov 13, 2014

My build is SegFaulting since this change... So there must be an issue with all this. As soon as dialectClass is used, almost all queries are going in Segmentation fault:

#0  zend_call_function (fci=0x7fff4f0be280, fci_cache=0x8) at /tmp/buildd/php5-5.4.34/Zend/zend_execute_API.c:837
#1  0x00007f6e6bc7fb9a in zephir_call_user_function () from /usr/lib/php5/20100525/phalcon.so
#2  0x00007f6e6bc621a6 in zephir_call_class_method_aparams () from /usr/lib/php5/20100525/phalcon.so
#3  0x00007f6e6ba9ffc2 in zim_Phalcon_Db_Dialect_select () from /usr/lib/php5/20100525/phalcon.so
#4  0x000000000069ba6d in zend_call_function (fci=0x7fff4f0be8a0, fci_cache=0x19053e8) at /tmp/buildd/php5-5.4.34/Zend/zend_execute_API.c:978
#5  0x00007f6e6bc7fc8f in zephir_call_user_function () from /usr/lib/php5/20100525/phalcon.so
#6  0x00007f6e6bc621a6 in zephir_call_class_method_aparams () from /usr/lib/php5/20100525/phalcon.so
#7  0x00007f6e6ba367ba in zim_Phalcon_Mvc_Model_Query__executeSelect () from /usr/lib/php5/20100525/phalcon.so

phalcon pushed a commit that referenced this pull request Nov 13, 2014
getSqlExpression() should not be final
@phalcon phalcon merged commit 62c791a into phalcon:2.0.0 Nov 13, 2014
@phalcon
Copy link
Collaborator

phalcon commented Nov 13, 2014

Thanks

@dugwood dugwood deleted the patch-3 branch November 13, 2014 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants