Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Swiftmailer and Twig to Composer "suggest" block #875

Closed
CameronHall opened this issue Nov 16, 2018 · 2 comments
Closed

Move Swiftmailer and Twig to Composer "suggest" block #875

CameronHall opened this issue Nov 16, 2018 · 2 comments

Comments

@CameronHall
Copy link
Contributor

I believe the libraries used for adapters that the incubator supports should be "suggested" instead of "required". It should be the developer's responsibility to require the library they need opposed to forcing a specific version and/or downloading a library that isn't going to be used.

My specific case being, that SwiftMailer is up to version six. I'd like to upgrade to that version but I'm held back by this library enforcing version 5.x. It's not the end of the world but it's frustrating and inconvenient.
@sergeyklay
Copy link
Contributor

@CameronHall Could you send a patch?

@CameronHall CameronHall mentioned this issue Nov 17, 2018
Merged
2 tasks
sergeyklay pushed a commit that referenced this issue Nov 19, 2018
@CameronHall @sergeyklay
#875: Swiftmailer and Twig are no longer required
1ea9ddd 
Moved Swiftmailer and Twig to the Composer "suggest"
sergeyklay pushed a commit that referenced this issue Nov 19, 2018
@CameronHall @sergeyklay
#875: Swiftmailer and Twig are no longer required
2ab139c 
Moved Swiftmailer and Twig to the Composer "suggest"
@CameronHall
Copy link
Contributor Author

Thanks @sergeyklay

Just released v3.4.3: https://github.com/phalcon/incubator/releases/tag/v3.4.3

sergeyklay pushed a commit that referenced this issue Jul 27, 2019
@ruudboon @sergeyklay
Sync with master (#912)
39d5bc8 
* #875: Swiftmailer and Twig are no longer required

Moved Swiftmailer and Twig to the Composer "suggest"

* Add new validator: ArrayInclusionIn

* Fix unit test

* Fix unit test - last test method

* Support for the TIMESTAMPDIFF

* Add options to ReCaptcha Validator to make it work with v3.

* Fixed PHPCS issues

* fix(oracle): Added missing interface method sharedLock

* Moved opening brace to newline as suggested

Co-Authored-By: lubber-de <c64@lubber.de>

* Translate Adapter for multi-column csv (#890)

* [Translate] add an intl MessageFormatter interpolator (#892)

* Tidied up READMEs.

* Applied PSR2 to tests.

* Code standards.

* Tidied up Annotations.

* Tidied up codebase.
ruudboon added a commit to ruudboon/incubator that referenced this issue Aug 30, 2019
@ruudboon
Sync with master (phalcon#912)
d2d33a2 
* phalcon#875: Swiftmailer and Twig are no longer required

Moved Swiftmailer and Twig to the Composer "suggest"

* Add new validator: ArrayInclusionIn

* Fix unit test

* Fix unit test - last test method

* Support for the TIMESTAMPDIFF

* Add options to ReCaptcha Validator to make it work with v3.

* Fixed PHPCS issues

* fix(oracle): Added missing interface method sharedLock

* Moved opening brace to newline as suggested

Co-Authored-By: lubber-de <c64@lubber.de>

* Translate Adapter for multi-column csv (phalcon#890)

* [Translate] add an intl MessageFormatter interpolator (phalcon#892)

* Tidied up READMEs.

* Applied PSR2 to tests.

* Code standards.

* Tidied up Annotations.

* Tidied up codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergeyklay @CameronHall