Make Smarty adapter compatible with nocache optional argument #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->_viewParams[$key] = $value; | ||
| $this->_viewParams["_" . $key] = $nocache; | ||
| } | ||
| } |
There was a problem hiding this comment.
Expected 1 newline at end of file; 0 found
Conflicts: Library/Phalcon/Mvc/View/SmartyView.php
sergeyklay
added a commit
that referenced
this pull request
Jul 31, 2015
Make Smarty adapter compatible with nocache optional argument
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third argument in Smarty's assign function is one of it's most important features, giving it a back-end friendly partial caching ability that other template engines often don't have (including Volt.) This SmartyView is a basic extension of View that enables usage of this important feature.
Almost any real web app would benefit from this feature, as a page will often have lots of static content that can be cached. However, a portion of it such as the username of the visitor who is currently logged in will change with each user.