Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate camelCase properties #1433

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Fix duplicate camelCase properties #1433

merged 2 commits into from
Apr 10, 2020

Conversation

terax6669
Copy link
Contributor

  • Type: bug fix

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
Regenerating an existing model with --force duplicates camelized properties.

@Jeckerson
Copy link
Member

@terax6669
Copy link
Contributor Author

Calling empty on a boolean value is almost certainly unintended
I guess he has a problem with the fact that this is an array of bools, but that'd mean that the previous code had the same error 😝

@jenovateurs
Copy link
Contributor

@terax6669, I fixed some errors with travis, maybe your code will be pass after you pull the last version of the code.

@Jeckerson
Copy link
Member

@terax6669 Can you rebase with latest changes in 4.0.x branch and see if CI errors gone?

@Jeckerson Jeckerson merged commit b0fed14 into phalcon:4.0.x Apr 10, 2020
@Jeckerson Jeckerson mentioned this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants