Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell resolution depends on order of CellCompleters #46

Open
JanKoelzer opened this issue Nov 11, 2017 · 0 comments
Open

Cell resolution depends on order of CellCompleters #46

JanKoelzer opened this issue Nov 11, 2017 · 0 comments

Comments

@JanKoelzer
Copy link
Contributor

resolveDefault and resolveCycle use the Key of the first cell of the HandlerPool. Therefore the order of the cells matters, which is unintuitive.
A test "whenNext: Cycle resolution, order of CellCompleters" can be found here: https://github.com/JanKoelzer/reactive-async/tree/jan-tests-cycles
JanKoelzer added a commit to JanKoelzer/reactive-async that referenced this issue Oct 12, 2018
@JanKoelzer
TEST Call key.resolve/key.fallback separately for each cell in a cSCC.
15b6c67 
This is related to phaller#46 but the slowest solution possible.

As in OPAL every cell has its onw key we cannot rely on taking the first
key available. So we call key.resolve for every cell and apply the
result after all invocations.
@JanKoelzer JanKoelzer mentioned this issue Dec 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JanKoelzer