Add testcase for #187 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filak-sap
pushed a commit
to SAP/python-pyodata
that referenced
this pull request
Jan 11, 2022
While Edm.Binary values are Base64 encoded in JSON payload [1][1], the specification demands a prefixed and quoted Base16 encoding for values in URIs and HTTP headers [2][2]. As there has been no specific conversion for Edm.Binary so far and we want to stay backward compatible, the Python side representation shall remain a string with the Base64 encoded payload. However there are cases, where the literal is generated from the payload and sent to the server, that expects it in the correct format. E.g. this happens when building the resource path while using a Edm.Binary property as an entity key (see #187 and phanak-sap/pyodata-issue-files#2). Another case might be when using the $include filter for a Edm.Binary property. To meet those requirements, we want to have these representations: JSON | Python | Literal --------|--------------|------------------------ Base64 | str (Base64) | prefixed quoted Base16 This adds a specific type for Edm.Binary with the necessary conversions. Further it extends the test cases to cover those conversions. As the Edm.Binary type has been used to test the generic prefixed conversions, we need to switch this to the Edm.Byte type, that remains generic. [1](https://www.odata.org/documentation/odata-version-2-0/json-format) [2](https://www.odata.org/documentation/odata-version-2-0/overview/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.