Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise source link for trailing slash removal rule #2 #64

Merged
merged 1 commit into from
Apr 9, 2015

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Apr 9, 2015

For the genesis and some extra explanations:
laravel/laravel#3145

@phanan
Copy link
Owner

phanan commented Apr 9, 2015

👍

phanan added a commit that referenced this pull request Apr 9, 2015
More precise source link for trailing slash removal rule #2
@phanan phanan merged commit 509d047 into phanan:master Apr 9, 2015
@vlakoff
Copy link
Contributor Author

vlakoff commented Apr 9, 2015

I don't have fresh remembering of all the details, but my rule set covers all the cases I can think of, so I suppose you could remove the 1st "remove trailing slash" rule set as it is now redundant.

@phanan
Copy link
Owner

phanan commented Apr 10, 2015

I'd be happy to accept another PR. Also, shouldn't your snippet's title be just "Remove Trailing Slash" then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants