Closes #2316_fix_skipped_test (#2319)

* Remove test about deprecation of na_val argument. Update comment in code.

* Update 2316 branch with latest main. (#2323)

* Closes #2309 Bypass undesirable_function_linter and indentation_linter checks, as … (#2322)

Bypass undesirable_function_linter and indentation_linter checks, as a temporary solution to failing CI checks.

* [skip actions] Bump version to 1.0.0.9005

* admiral v1.0.1 - Hotfix for derive_vars_query (#2311) (#2320)

* Closes #2311 attend to `derive_vars_query()` bug (#2313)

* new branch here

* fix typo in news

* 2311 updated unit test to have mixed case

* missing the toupper part

* add more detail to news

* fix links

* add documentation on case insensitivity

---------

Co-authored-by: Gordon Miller <gordon.miller@roche.com>

* chore: #2311 remove renv to get website to build

* [actions skip] Add/Update README.md for patch

* Trigger Build

---------

Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
Co-authored-by: Gordon Miller <gordon.miller@roche.com>
Co-authored-by: GitHub Actions <action@github.com>

---------

Co-authored-by: bms63 <bms63@users.noreply.github.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
Co-authored-by: Gordon Miller <gordon.miller@roche.com>
Co-authored-by: GitHub Actions <action@github.com>

---------

Co-authored-by: bms63 <bms63@users.noreply.github.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
Co-authored-by: Gordon Miller <gordon.miller@roche.com>
Co-authored-by: GitHub Actions <action@github.com>

R/derive_var_shift.R

@@ -79,7 +79,7 @@ derive_var_shift <- function(dataset,
   sep_val <- assert_character_scalar(sep_val)
   assert_data_frame(dataset, required_vars = exprs(!!from_var, !!to_var))
 
-  # Derive shift variable. If from_var or to_var has missing value then set to na_val.
+  # Derive shift variable. If from_var or to_var has missing value then set to missing_value.
   dataset %>%
     mutate(
       temp_from_var = if_else(is.na(!!from_var), !!missing_value, as.character(!!from_var)),

tests/testthat/test-derive_var_shift.R

@@ -129,16 +129,3 @@ test_that("derive_var_shift Test 4: Shift with user-specified missing_value and
     expected_output
   )
 })
-
-## Test 5: Test deprecation warning of na_val argument ----
-test_that("derive_var_shift Test 5: Test deprecation warning of na_val argument", {
-  input <- tibble::tribble(
-    ~USUBJID, ~PARAMCD, ~AVAL, ~ABLFL, ~BNRIND, ~ANRIND,
-    "P01", "ALB", 33, "Y", "LOW", "LOW",
-    "P01", "ALB", 38, NA, "LOW", "NORMAL",
-    "P01", "ALB", NA, NA, "LOW", NA,
-    "P02", "ALB", NA, "Y", NA, NA,
-    "P02", "ALB", 49, NA, NA, "HIGH",
-    "P02", "SODIUM", 147, "Y", "HIGH", "HIGH"
-  )
-})