Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Make derive_extreme_records() consistent with the other functions #2139

Closed
bundfussr opened this issue Sep 28, 2023 · 0 comments · Fixed by #2192
Closed

Feature Request: Make derive_extreme_records() consistent with the other functions #2139

bundfussr opened this issue Sep 28, 2023 · 0 comments · Fixed by #2192
Assignees
@jeffreyad
Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming

Comments

@bundfussr
Copy link
Collaborator

Feature Idea

derive_extreme_records() should be made consistent with the other admiral function:

  • The dataset_add argument should be mandatory.
  • The default value of false_value should be NA_character_.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@bundfussr bundfussr added enhancement New feature or request programming function re-work issues identified by function re-work gang - usually argument alignment, user friendliness release Q4-2023 labels Sep 28, 2023
@jeffreyad jeffreyad self-assigned this Oct 17, 2023
jeffreyad added a commit that referenced this issue Oct 25, 2023
@jeffreyad
#2139 chore: Make dataset_add mandatory for derive_extreme_records()
8f81727
@jeffreyad jeffreyad linked a pull request Oct 25, 2023 that will close this issue
Closes #2139 Make derive_extreme_records() consistent #2192
Merged
14 tasks
jeffreyad added a commit that referenced this issue Oct 25, 2023
@jeffreyad
#2139 Add mandatory dataset_add to examples
10ced2e
bms63 pushed a commit that referenced this issue Nov 3, 2023
@jeffreyad
Closes #2139 Make derive_extreme_records() consistent (#2192)
4fd22ce 
* #2139 chore: Make dataset_add mandatory for derive_extreme_records()

* #2139 Add mandatory dataset_add to examples

* #2130 Chore: Update derive_extreme_records from review comments

---------

Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreyad jeffreyad

Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2139 Make derive_extreme_records() consistent pharmaverse/admiral
2 participants
@bundfussr @jeffreyad