Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: Supersede derive_param_extreme_record() #2141

Closed
bundfussr opened this issue Sep 28, 2023 · 0 comments · Fixed by #2174
Closed

General Issue: Supersede derive_param_extreme_record() #2141

bundfussr opened this issue Sep 28, 2023 · 0 comments · Fixed by #2174
Assignees
@ddsjoberg
Labels
function re-work issues identified by function re-work gang - usually argument alignment, user friendliness general issue

Comments

@bundfussr
Copy link
Collaborator

Background Information

derive_param_extreme_record() should be superseded in favor of derive_extreme_event().

The superseded badge should be added to its documentation and @keywords and @family should be changed to superseded. A "Superseded" section should be added to the reference page.

Definition of Done

No response
@bundfussr bundfussr added general issue function re-work issues identified by function re-work gang - usually argument alignment, user friendliness release Q4-2023 labels Sep 28, 2023
@ddsjoberg ddsjoberg mentioned this issue Oct 19, 2023
Merged
14 tasks
@ddsjoberg ddsjoberg self-assigned this Oct 19, 2023
bms63 added a commit that referenced this issue Oct 25, 2023
@bms63
feat: #2141 supersede section
224dd41
bms63 added a commit that referenced this issue Oct 25, 2023
@bms63
chore: #2141 docs
b82ce45
bms63 added a commit that referenced this issue Oct 25, 2023
@ddsjoberg @zdz2101 @bms63
Closes #2141 Superseded derive_param_extreme_record() (#2174)
dd8f8d9 
* superseded fun

* Update NEWS.md

* added badge

* doc update

* feat: #2141 supersede section

* chore: #2141 docs

---------

Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddsjoberg ddsjoberg

Labels
function re-work issues identified by function re-work gang - usually argument alignment, user friendliness general issue
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2141 Superseded derive_param_extreme_record() pharmaverse/admiral
2 participants
@ddsjoberg @bundfussr