Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ADPP/ADPC template #2308

Closed
2 tasks done
kaz462 opened this issue Jan 24, 2024 · 3 comments · Fixed by #2333
Closed
2 tasks done

update ADPP/ADPC template #2308

kaz462 opened this issue Jan 24, 2024 · 3 comments · Fixed by #2333
Assignees
@jeffreyad
Labels
good first issue Good for newcomers

Comments

@kaz462
Copy link
Collaborator

kaz462 commented Jan 24, 2024 •
edited by jeffreyad
Loading

Background Information

Issues from pharmaverseadam: pharmaverse/pharmaverseadam#57

Definition of Done

  • ADPP.AVISIT/AVISITN variables are empty - update adpp template to populate them

  • AVALU is currently missing in ADPP/ADPC, consider to derive this from PPORRESU/PCORRESU in adpp template and adpc template
@kaz462 kaz462 added general issue good first issue Good for newcomers and removed general issue labels Jan 24, 2024
@kaz462 kaz462 mentioned this issue Jan 24, 2024
Closed
4 tasks
@bms63
Copy link
Collaborator

bms63 commented Jan 24, 2024

@pharmaverse/admiral @pharmaverse/admiral_comm hey all - this is a pretty quick fix.

nice spot @kaz462!!

@jeffreyad jeffreyad self-assigned this Jan 30, 2024
@jeffreyad
Copy link
Collaborator

@kaz462 looks like AVALU is populated in ADPC. I will update it in ADPP.

jeffreyad added a commit that referenced this issue Feb 12, 2024
@jeffreyad
Update ADPP and ADPC templates #2308 #2328
97209cb
@jeffreyad jeffreyad linked a pull request Feb 12, 2024 that will close this issue
Closes #2308 #2328 Update ADPP and ADPC templates #2333
Merged
15 tasks
@jeffreyad
Copy link
Collaborator

VISIT and VISITNUM are not in PP, which is not unusual. I defined AVISIT based on ADY which I think is reasonable. I did set VISIT and VISITNUM to the same values but these variables are not necessary in ADPP so they could be dropped if desired.

bms63 pushed a commit that referenced this issue Feb 13, 2024
@jeffreyad
Closes #2308 #2328 Update ADPP and ADPC templates (#2333)
f71778f 
Update ADPP and ADPC templates #2308 #2328

Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreyad jeffreyad

Labels
good first issue Good for newcomers
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2308 #2328 Update ADPP and ADPC templates pharmaverse/admiral
3 participants
@bms63 @kaz462 @jeffreyad