Fix/cran status issues duplicates #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdguy
reviewed
Jan 24, 2023
| } | ||
| } else { | ||
| print(paste("ERROR ACCESSING URL=", url)) | ||
| } |
There was a problem hiding this comment.
Let's fix the styling here. Use the styler R package to fix it.
| @@ -0,0 +1,2 @@ | |||
| #!/usr/bin/env bash | |||
| Rscript /app/check-status.R --status_types "${INPUT_STATUS_TYPES}" | |||
There was a problem hiding this comment.
Suggested change
| Rscript /app/check-status.R --status_types "${INPUT_STATUS_TYPES}" | |
| Rscript /app/check-status.R --status_types "${INPUT_STATUSES}" | |
This will align with the input being renamed to statuses
.github/workflows/cran-status.yml
Outdated
| @@ -14,12 +14,12 @@ on: | |||
| default: '' | |||
| required: false | |||
| type: string | |||
| status-types: | |||
| status_types: | |||
There was a problem hiding this comment.
Why does this need to change?
There was a problem hiding this comment.
Maybe let's rename this to statuses, so that we don't have to worry about - vs _
cicdguy
reviewed
Jan 27, 2023
| ) | ||
| } | ||
|
|
||
| build_md5_codes <- function(pkg, errors, step) { |
There was a problem hiding this comment.
Rename this to compute_md5_hash
.github/workflows/cran-status.yml
Outdated
| @@ -14,12 +14,12 @@ on: | |||
| default: '' | |||
| required: false | |||
| type: string | |||
| status-types: | |||
| status_types: | |||
There was a problem hiding this comment.
Maybe let's rename this to statuses, so that we don't have to worry about - vs _
cicdguy
reviewed
Jan 27, 2023
|
Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.