Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top 5 packages based on GitHub Stars #202

Merged
merged 24 commits into from
Aug 15, 2024
Merged

Top 5 packages based on GitHub Stars #202

merged 24 commits into from
Aug 15, 2024

Conversation

gigikenneth
Copy link
Collaborator

@gigikenneth gigikenneth commented Jul 31, 2024

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes Blog Post: Top 5 Repos based on GitHub Stars and honorable mention? #186 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, add your own tag! We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@gigikenneth gigikenneth self-assigned this Jul 31, 2024
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa...this is way cool!!

@bms63
Copy link
Collaborator

bms63 commented Aug 1, 2024

Could you add the packages needed for this blog to this list in the readme https://github.com/pharmaverse/blog?tab=readme-ov-file#tips-and-tricks and in the gh action that publishes the site please

@bms63
Copy link
Collaborator

bms63 commented Aug 1, 2024

Were you able to build this site locally. mine is hanging
image

added teal, rtables, riskmetric and tidycdisc
added rtables, teal, riskmetric, tidyCDISC
@gigikenneth
Copy link
Collaborator Author

gigikenneth commented Aug 1, 2024

Were you able to build this site locally. mine is hanging image

Hi! I mistakenly added r tags to the code blocks and that caused the issue. I've taken them out. Hopefully it should work now. @bms63

I've added the packages to the readme and publish.yaml

@gigikenneth
Copy link
Collaborator Author

The spellcheck errors are mostly coming from the links and some abbreviations.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post @gigikenneth ! I left some comments. Spelling can be fixed by adding words to inst/wordlist.

gigikenneth and others added 9 commits August 1, 2024 17:44
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
…es.qmd

Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
@gigikenneth
Copy link
Collaborator Author

Hi @manciniedoardo , please I need help. the spellcheck is failing for one word. I've updated it in the doc but it's not working 🫠

@manciniedoardo
Copy link
Collaborator

Hi @manciniedoardo , please I need help. the spellcheck is failing for one word. I've updated it in the doc but it's not working 🫠

There was a space after "XPORT". I removed that and took the opportunity to re-sort the WORDLIST as it was getting out of hand.

@manciniedoardo
Copy link
Collaborator

@gigikenneth @bms63 could we please make an effort to merge in this week in order to fit this post into the Aug newsletter? thanks 😄

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a spurious blog post here? My test blog?

@gigikenneth
Copy link
Collaborator Author

I think there is a spurious blog post here? My test blog?

@manciniedoardo I've deleted the test blog 🙏🏾

@manciniedoardo manciniedoardo self-requested a review August 15, 2024 07:45
Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @gigikenneth !

@manciniedoardo manciniedoardo self-requested a review August 15, 2024 07:45
@manciniedoardo manciniedoardo merged commit fe77f47 into main Aug 15, 2024
5 checks passed
@manciniedoardo manciniedoardo deleted the top-five branch August 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog Post: Top 5 Repos based on GitHub Stars and honorable mention?
3 participants