-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite test filter #106
Composite test filter #106
Conversation
@@ -0,0 +1,57 @@ | |||
Class { | |||
#name : 'MTCompositeTestFilter', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a class comment? Does this filter filters if ALL filters say so, or if ANY filter does it? I assume it should be ANY (otherwise it will be unusable, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It filters if any filter does. It's as if the tests collection passes through each filter one by one.
I'll add a class comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Added
MTCompositeTestFilter
to combine several test filters.Use it by giving a collection of filters:
Also simplified tests for test filters