Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite test filter #106

Merged

Conversation

DurieuxPol
Copy link
Collaborator

Added MTCompositeTestFilter to combine several test filters.
Use it by giving a collection of filters:

MTCompositeTestFilter for: {
		(MTBlockTestFilter for: [ :testCase |
			 testCase selector beginsWith: 'testX' ]).
		(MTPragmaSelectionTestFilter for: #pragma).
		(MTTimeTestFilter for: 10 milliSeconds) }

Also simplified tests for test filters

@DurieuxPol DurieuxPol requested a review from guillep April 4, 2024 14:08
@@ -0,0 +1,57 @@
Class {
#name : 'MTCompositeTestFilter',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a class comment? Does this filter filters if ALL filters say so, or if ANY filter does it? I assume it should be ANY (otherwise it will be unusable, right?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It filters if any filter does. It's as if the tests collection passes through each filter one by one.
I'll add a class comment

Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@guillep guillep merged commit cfb75f3 into pharo-contributions:master Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants