Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default values of analysis #110

Merged
merged 17 commits into from
Apr 16, 2024

Conversation

DurieuxPol
Copy link
Collaborator

I changed some default values of MTAnalysis that can easily be modified. I'll push the others when they are done.

@DurieuxPol DurieuxPol requested a review from guillep April 9, 2024 15:17
@DurieuxPol
Copy link
Collaborator Author

DurieuxPol commented Apr 10, 2024

I updated all default values. However I still have a few concerns about some of them.
I feel like the default logger should be the null one, because how much the transcript one writes in the transcript and even in the log of the github actions. I don't know if it could lead to problems like memory problems.

Also, the budget is a bit hard to adjust, because most of the time the tests don't take much time to run (less than a second). So to make sure that a least a few mutants are evaluated I multiplied the total test time by 30, but it's a bit random. And even multiplying by 30 there is often no mutants evaluated.
So should I increase this number up to 100 for example ?

Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is very cool work :)

I think we can do a little pass before integration

@guillep
Copy link
Contributor

guillep commented Apr 15, 2024

I updated all default values. However I still have a few concerns about some of them. I feel like the default logger should be the null one, because how much the transcript one writes in the transcript and even in the log of the github actions. I don't know if it could lead to problems like memory problems.

Also, the budget is a bit hard to adjust, because most of the time the tests don't take much time to run (less than a second). So to make sure that a least a few mutants are evaluated I multiplied the total test time by 30, but it's a bit random. And even multiplying by 30 there is often no mutants evaluated. So should I increase this number up to 100 for example ?

I like these two concerns :) This shows that doing this is not as straight forward as we may think.
Could you open two issues for this? I think we should work on this on priority.

@DurieuxPol
Copy link
Collaborator Author

DurieuxPol commented Apr 15, 2024

I like these two concerns :) This shows that doing this is not as straight forward as we may think. Could you open two issues for this? I think we should work on this on priority.

Done !

Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed a couple of changes, let's talk quickly

src/MuTalk-Model/MTAnalysis.class.st Outdated Show resolved Hide resolved
src/MuTalk-Model/MTAnalysis.class.st Outdated Show resolved Hide resolved
@guillep guillep merged commit 639f4c6 into pharo-contributions:master Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants