-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General result shows filtered tests #84
Merged
guillep
merged 11 commits into
pharo-contributions:master
from
DurieuxPol:enh/resultRapport
Mar 14, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
71d658e
added filtered tests in mutalk general result
8d6bae6
added filtered test reasons, and attempt to improve filtered test in …
dc23784
fix filtered tests in general result
7a6ed52
added basic view of test code
536c407
Merge 044fb70bc0fcd68099c53f2257a8aad52aba37d7
af5f974
added filteredTestReason to new filters
f0fd31d
changed text presenter to code presenter
781862e
improved code presenter
e6e1ba6
fixed test
b0af3ad
added excluded tests and filtered tests as instance variables + refactor
8e493f1
adapt analysis to new structure of test filters & rename everything "…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
Class { | ||
#name : 'MTExcludedTestsPresenter', | ||
#superclass : 'MTMutationResultsPresenter', | ||
#instVars : [ | ||
'testCodePresenter' | ||
], | ||
#category : 'MuTalk-SpecUI', | ||
#package : 'MuTalk-SpecUI' | ||
} | ||
|
||
{ #category : 'initialization' } | ||
MTExcludedTestsPresenter >> connectPresenters [ | ||
|
||
tablePresenter whenSelectionChangedDo: [ :selection | | ||
| selectedItem | | ||
selectedItem := selection selectedItem. | ||
testCodePresenter | ||
beForMethod: selectedItem key method; | ||
text: selectedItem key method sourceCode; | ||
beNotEditable ] | ||
] | ||
|
||
{ #category : 'layout' } | ||
MTExcludedTestsPresenter >> defaultLayout [ | ||
|
||
^ SpPanedLayout newTopToBottom | ||
add: tablePresenter; | ||
add: testCodePresenter; | ||
yourself | ||
] | ||
|
||
{ #category : 'initialization' } | ||
MTExcludedTestsPresenter >> initializePresenters [ | ||
|
||
tablePresenter := self newTable. | ||
tablePresenter | ||
items: model; | ||
activateOnSingleClick; | ||
addColumn: (SpStringTableColumn | ||
title: 'ExcludedTests' | ||
evaluated: [ :each | each key ]); | ||
addColumn: | ||
(SpStringTableColumn | ||
title: 'Reason' | ||
evaluated: [ :each | each value ]). | ||
|
||
testCodePresenter := self newCode. | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is weird... why is it attaching
>
at the end of the string?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
reasonString
is the start of the string, and it contains<
.It's because I wanted the pragma to be between <>, like this
<pragma>