Adding PHP 7.4 #20
Open
Adding PHP 7.4 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaunceyt
reviewed
Jun 19, 2020
| php74-php-gd \ | ||
| php74-php-mbstring \ | ||
| php74-php-mcrypt \ | ||
| php74-php-pecl-memcached \ |
There was a problem hiding this comment.
In this PR https://github.com/phase2/docker-build/pull/47/files#diff-ce24a4205ce621c14ac1849960b386aaR38 you're bring in php74-php-pecl-memcache was this intentional?
There was a problem hiding this comment.
I copied the php73 files and then search/replaced them so I'm not sure why that difference is there. It seems like we would want to be consistent between them so I'll troll through the git logs and see if I can spot anything about why either one was picked. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.