Better sync detection and configuration via environmental variables #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mental variables
Contributor
|
Would mtime be simpler/more efficient? |
Contributor
|
The failure of the branch implies the need to run |
Member
Author
|
There doesn't appear to be any code advantage to trying to work with mtime, it's actually a little more complex due to needing to deal with the time type. It also doesn't appear to offer any speed advantages in terms of allowing a shorter pause between checks. It may be slightly more efficient but I don't have any data to know whether go is actually going to fetch all the stat data data regardless and then just push back the piece we need. Regardless, we're not checking frequently enough that I think efficiency at this scale is of concern. I'll run stuff through gofmt and push up an update. |
Side effect of increasing the timeout for container start but the actual syncing is the thing that has proven most problematic so far.
… it is configurable.
This prevents a spurious message about being unable to sync the tmp file showing in the logs as it was usually getting removed before the sync finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually waits for the unison log file to stop growing before claiming that the initial sync is done.