Skip to content

Conversation

rohan-chaturvedi
Copy link
Member

💡 Proposed Changes

  • Use more robust parsing of route params, rather than splitting the pathname string
  • Add breadcrumbs for all available page routes
  • Add programmatic page titles

🖼️ Screenshots or Demo

image image image image image

🎯 Reviewer Focus

Verify that the breadcrumbs and page titles are correct for all page routes (app and org pages)

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Update migrations (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@rohan-chaturvedi rohan-chaturvedi added enhancement New feature or request frontend Change in frontend code labels Aug 4, 2025
@nimish-ks
Copy link
Member

@cursor review

label: page,
isLink: Boolean(activeApp),
})
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Breadcrumb Missing Context, Page Not Clickable

The breadcrumb component has a couple of issues. It incorrectly omits the context segment (e.g., "access") when a page is also present, leading to incomplete paths like "team / users". This happens because the context is only added if page is undefined. Additionally, the page breadcrumb is not clickable as its href property is missing, even when isLink is true.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Change in frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants