Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom kms hosts #5

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

rohan-chaturvedi
Copy link
Member

Description

Adds support for using the SDK with a custom kms host. The client can now be initialized with an optional host argument provided to the constructor:

phase = Phase(APP_ID, APP_SECRET, KMS_HOST)

Changes

  • Added _kms_host as a class variable
  • Updated the Phase class constructor to accept an optional custom_kms_host argument
  • Set the _kms_host to the provided custom host if available, else use the default kms host
  • Updated the fetch_app_key function to accept the kms host as an argument
  • Updated tests
  • Bumped version to 1.1.0

@rohan-chaturvedi rohan-chaturvedi merged commit f495358 into main Jun 13, 2023
@rohan-chaturvedi rohan-chaturvedi deleted the custom-kms-host branch June 13, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants