Skip to content

Commit

Permalink
DataManager.pop would emit the DataManager instance, instead of the…
Browse files Browse the repository at this point in the history
… parent, as the first event argument. It now emits the parent as it should do. Fix #4186
  • Loading branch information
photonstorm committed Jan 24, 2019
1 parent fac2efe commit 4fea7f5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ one set of bindings ever created, which makes things a lot cleaner.
* The WebGLRenderer will now apply a transparent background if `transparent = true` in the game config (thanks @gomachan7)
* `List.sort` was missing the scope required for the sort handler, this is now correctly provided internally. Fix #4241 (thanks @jcyuan)
* `Container.sort` was missing the scope required for the sort handler, this is now correctly provided internally. Fix #4241 (thanks @jcyuan)
* `DataManager.pop` would emit the DataManager instance, instead of the parent, as the first event argument. It now emits the parent as it should do. Fix #4186 (thanks @gadelan)

### Examples and TypeScript

Expand Down
2 changes: 1 addition & 1 deletion src/data/DataManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ var DataManager = new Class({
delete this.list[key];
delete this.values[key];

this.events.emit(Events.REMOVE_DATA, this, key, data);
this.events.emit(Events.REMOVE_DATA, this.parent, key, data);
}

return data;
Expand Down

0 comments on commit 4fea7f5

Please sign in to comment.