Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard getScores doesn't take count and offset in parameter. #4271

Closed
Oramy opened this issue Jan 2, 2019 · 1 comment
Closed

Leaderboard getScores doesn't take count and offset in parameter. #4271

Oramy opened this issue Jan 2, 2019 · 1 comment

Comments

@Oramy
Copy link
Contributor

Oramy commented Jan 2, 2019

Version

  • Phaser Version: 3.10.1
  • Operating system: Windows
  • Browser: Firefox

Description

This bug is simple. The count and offset parameters of the getScores method of the Leaderboard class are fixed to their default value. Inspecting the code shows that they are not passed as parameters to the Facebook API.
I tried to show the first place of my leaderboard but the next results showed up.

Example Test Code

I cannot really provide an example code as to be reproduced it needs a Facebook Leaderboard.

Additional Information

The solution is to add arguments to getEntriesAsync in the Leaderboard method.
I will try to make a pull request.

Thanks for making this engine.

Oramy pushed a commit to Oramy/phaser that referenced this issue Jan 2, 2019
photonstorm added a commit that referenced this issue Jan 4, 2019
@photonstorm
Copy link
Collaborator

Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the master branch and attributed the work to you in the Change Log. If you need to tweak the code for whatever reason please submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants