New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn, throw for particle texture frame mistakes #5841

Merged

photonstorm merged 2 commits into phaserjs:master from samme:feature/warn-particle-missing-frame

Sep 24, 2021

Contributor

samme commented Sep 23, 2021

This PR

Adds a new feature

Closes #5838

In Particle#fire(), an error is thrown if the particle has no texture frame. This prevents an uncaught error later when the particle fails to render.
In ParticleEmitterManager#setEmitterFrames(), console warnings are printed if an invalid texture frame is given or if no texture frames were set.

samme added 2 commits

September 23, 2021 11:15


          Warn for missing texture frames

da86ea7


          Throw an error for missing particle texture frame

023336f

photonstorm merged commit cca537b into phaserjs:master

Collaborator

photonstorm commented Sep 24, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet