This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 345
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix error when bundle in rails 6.0.3.1
- Loading branch information
hoangth
committed
Nov 17, 2020
1 parent
b2ee978
commit bec97d5
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bec97d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks older applications, that depend on Rails 5.
This wouldn't be a problem if you had incremented the devise_security_extension version, probably to 0.11.0, or more realistically (for a breaking change) 1.0.0.
I understand this gem is not under maintenance, but to break a currently-good version without altering the gem version is a big problem.
@hoangth
bec97d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem here.