This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
<Deny newer password than> feature in password_archivable #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieujobin
force-pushed
the
deny_newer_password_than
branch
from
4dc2c29 to
3cd791e
Compare
mathieujobin
changed the title
|
this allow to configure devise password_archivable module to deny passwords not only based on counts, but on how old they are. you can use both options together or separately cheers, |
|
@mm what do you think of this ? |
|
ping |
|
anything preventing this from being merged? thank you |
|
@manno any comments on this? |
|
I spent a good amount of time making sure I was respecting the style of the gem. and adding every bits thank you |
|
this will be 2 years old soon enough, closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.