This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Rails5 deprecation fixes #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tried to rebase this one, but afterwards the tests were failing. |
…Just nesting everything under `params` solves this.
…ards compatibility with Rails versions.
natebird
force-pushed
the
rails5_deprecation_fixes
branch
from
2682ab4 to
fc8ab99
Compare
|
Not sure if that rebase went how it was supposed to but all the changes are there and everything is passing now. |
|
👍 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a lot of deprecation warnings generated by Rails 5.x.