Skip to content

Commit

Permalink
Using jsr305 jar for #66
Browse files Browse the repository at this point in the history
  • Loading branch information
phax committed Feb 25, 2019
1 parent ae01cb6 commit cc9825b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ A site with the links to the [API docs](http://phax.github.io/jcodemodel/) etc.

# News and noteworthy

* v3.2.2 - 2019-02-25
* Using `jsr305` instead of `annotations` in POM (issue #66 from @jjYBdx4IL)
* v3.2.1 - 2019-01-23
* Added `var` as reserved word
* Made `JReturn` constructor public
Expand Down Expand Up @@ -106,12 +108,14 @@ A site with the links to the [API docs](http://phax.github.io/jcodemodel/) etc.
* 2013-09-23: Changes from https://github.com/UnquietCode/JCodeModel have been incorporated.

## Maven usage

Add the following to your pom.xml to use this artifact:
```

```xml
<dependency>
<groupId>com.helger</groupId>
<artifactId>jcodemodel</artifactId>
<version>3.2.1</version>
<version>3.2.2</version>
</dependency>
```

Expand Down
5 changes: 3 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,11 @@
</contributors>

<dependencies>
<!-- We need jsr305 and not annotations because SuppressFBWarnings is contained! -->
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>annotations</artifactId>
<version>3.0.1u2</version>
<artifactId>jsr305</artifactId>
<version>3.0.2</version>
</dependency>

<dependency>
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/com/helger/jcodemodel/util/JCEqualsHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@
import javax.annotation.Nullable;
import javax.annotation.concurrent.Immutable;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

/**
* A small helper class that provides helper methods for easy
* <code>equals</code> method generation
Expand Down Expand Up @@ -180,7 +178,6 @@ public static boolean isEqual (@Nullable final Object aObj1, @Nullable final Obj
return aObj1.equals (aObj2);
}

@SuppressFBWarnings ({ "ES_COMPARING_PARAMETER_STRING_WITH_EQ" })
public static boolean nullSafeEqualsIgnoreCase (@Nullable final String sObj1, @Nullable final String sObj2)
{
return sObj1 == null ? sObj2 == null : sObj1.equalsIgnoreCase (sObj2);
Expand Down

0 comments on commit cc9825b

Please sign in to comment.