Ant: Add new failure controller attribute

[stefan-jung]

I like to break the build for some error levels, not for all. The failOnError is boolean, so cannot be used to do this. What I'd like to have is something like this:

failOnRole="fatal,error,warning"

[phax]

fyi: currently there is a heuristics contained that takes into consideration:

• for fatal error: fatal, fatalerror, fatal_error, fatal-error (since 5.0.2)
• for error: error, err
• for warning: warning, warn
• for information (since 5.0.2): information, info, notice, note.

[phax]

I did it slightly different. There is a list of errorRole elements that define additional role and flag values that are interpreted as error. E.g.

      <errorRole role="foo" />
      <errorRole role="bar" />

These error roles are handle with precendence, but if not contained, it falls back to the default error levels as stated above.

[fviolette]

Do you confirm <report>s are properly handled according to the errorRole(s) defined?

With failOnError set to true and <errorRole role="fatal"/>, my test chokes on the first <report test="." role="info">...</report>.

It is properly ignored when turning it into <assert test="not(.)" role="info">...</assert>.

[phax]

@fviolette I added a second unit test for this issue with "report" elements. And to me it looks fine.
But there is an incosnstency in your test: "errorRole" uses "fatal", the "report" uses "info" - was that accidental?

[fviolette]

I meant the report role="info" returned an error, which I did not expect by setting . Did I misunderstand anything?

I am going to check your unit test and double check my issues.

[phax]

Thanks all. Found it. Sorry - copy paste error for reports only :( Will do 5.0.5 asap

[fviolette]

You seriously rule!

[fviolette]

All good now.

[phax]

Excellent - thanks for rechecking!