We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
Noticed a small issue with the Directory REST API related to the total-result-count not actually being what it advertises.
For example when using the UI and querying for the word "test" it says that there are around 3000 hits. https://test-directory.peppol.eu/public/locale-en_US/menuitem-search?q=test
But doing that same query using the API, the total is always just the size of the result set. https://test-directory.peppol.eu/search/1.0/json?q=test&rpc=1 https://test-directory.peppol.eu/search/1.0/json?q=test&rpc=50
This makes it impossible to actually know when paging should be applied.
Think the API implementation needs to do a explicit count for the query, as the UI is doing here: https://github.com/phax/phoss-directory/blob/master/phoss-directory-publisher/src/main/java/com/helger/pd/publisher/app/pub/page/PagePublicSearchSimple.java#L162
The text was updated successfully, but these errors were encountered:
Fixing total result count; #39
1d4c835
Further fix for #39
15ce86e
Fixed in 0.8.0 release - thanks for pointing out. Will try to get it on the test server asap.
Sorry, something went wrong.
Great! Thanks for the super-fast response.
phax
No branches or pull requests
Hi,
Noticed a small issue with the Directory REST API related to the total-result-count not actually being what it advertises.
For example when using the UI and querying for the word "test" it says that there are around 3000 hits. https://test-directory.peppol.eu/public/locale-en_US/menuitem-search?q=test
But doing that same query using the API, the total is always just the size of the result set.
https://test-directory.peppol.eu/search/1.0/json?q=test&rpc=1
https://test-directory.peppol.eu/search/1.0/json?q=test&rpc=50
This makes it impossible to actually know when paging should be applied.
Think the API implementation needs to do a explicit count for the query, as the UI is doing here: https://github.com/phax/phoss-directory/blob/master/phoss-directory-publisher/src/main/java/com/helger/pd/publisher/app/pub/page/PagePublicSearchSimple.java#L162
The text was updated successfully, but these errors were encountered: