fix: appimage bundle fails due to incompatible binaries in linux, Fix mac m1 sign issues #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abose
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux fixes
LMDB pulls in binaries that contain
muslbased libs instead ofglibc. since all debina destors useglibcand notmusl, removing this repo will have no effect on ubuntu/debial and derivatives.Appimages currently need glibc to work, so the appimage itself wont load in all distros that doesnt have glibc even withouit this dependency:
So its safe to remove the files as appimage wont work anyway in distros that doesnt support glibc.
Mac fixes
Added binaries for mac m1 signature.