Use async version of elm compiler to be able to get the error message #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to be able to display the error message on the screen, for that I need to capture the error message produced during a compilation error, but this is not possible because the sync function from node-elm-compiler returns just a hardcoded string, as you can see here: rtfeldman/node-elm-compiler#110 Since we are already in an async function, we might as well just use await here and get the proper error message
|
Unfotunately, as mentioned in #2, this can result in compilation failing occasionally due to corrupt builds.
Can you elaborate a bit on this? The error messages generated by elm are piped through to stderr so not sure what you mean by this. |
|
@phenax when I'm focusing on build the UI, I rely on hot reloading to refresh the screen, having just the code and the browser open side by side, so I wanted to display the errors in the DOM directly (like phoenix does when there is a backend error), with an overlay, not having to switch to the terminal |
|
@rogeriochaves As mentioned in #2, this could lead to broken builds so I think this issue should be fixed upstream instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to display the error message on the screen, for that I need to capture the error message produced during a compilation error, but this is not possible because the sync function from node-elm-compiler returns just a hardcoded string, as you can see here: rtfeldman/node-elm-compiler#110
Since we are already in an async function, we might as well just use await here and get the proper error message