Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update term/property_neighbors/subject to work with relation graph #388

Merged
merged 7 commits into from
Feb 22, 2021

Conversation

Shalsh23
Copy link
Contributor

No description provided.

@Shalsh23 Shalsh23 self-assigned this Feb 18, 2021
@Shalsh23
Copy link
Contributor Author

Shalsh23 commented Feb 18, 2021

Test 1:

term: http://purl.obolibrary.org/obo/UBERON_0011618
property: http://purl.obolibrary.org/obo/RO_0000053

Old KB:

Not designed to return results for any IRI other than that of part_of.

New KB:
direct: true

curl -X GET "http://localhost:8082/term/property_neighbors/subject?term=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUBERON_0011618&property=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FRO_0000053&direct=true" -H "accept: application/json"
{"results":[{"@id":"http://purl.obolibrary.org/obo/PATO_0001993","label":"multicellular"}]}

@Shalsh23
Copy link
Contributor Author

Shalsh23 commented Feb 18, 2021

Test 2:

term: http://purl.obolibrary.org/obo/UBERON_0011618
property: http://purl.obolibrary.org/obo/BFO_0000050

Old KB:

curl -X GET "https://kb.phenoscape.org/api/term/property_neighbors/subject?term=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUBERON_0011618&property=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FBFO_0000050" -H "accept: application/json"
{
  "results": [
    {
      "@id": "http://purl.obolibrary.org/obo/UBERON_0002513",
      "label": "endochondral bone"
    },
    {
      "@id": "http://purl.obolibrary.org/obo/UBERON_0011614",
      "label": "basihyal element"
    }
  ]
}

New KB:

direct: true

curl -X GET "http://localhost:8082/term/property_neighbors/subject?term=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUBERON_0011618&property=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FBFO_0000050&direct=true" -H "accept: application/json"
{"results":[{"@id":"http://purl.obolibrary.org/obo/UBERON_0011153","label":"ventral hyoid arch skeleton"}]}

direct: false

curl -X GET "http://localhost:8082/term/property_neighbors/subject?term=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUBERON_0011618&property=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FBFO_0000050&direct=false" -H "accept: application/json"
{"results":[{"@id":"http://purl.obolibrary.org/obo/BFO_0000002","label":"continuant"},{"@id":"http://purl.obolibrary.org/obo/BFO_0000004","label":"independent continuant"},{"@id":"http://purl.obolibrary.org/obo/BFO_0000040","label":"material entity"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000000","label":"anatomical entity"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000000","label":"anatomical entity"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000003","label":"connected anatomical structure"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000003","label":"anatomical structure"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000006","label":"material anatomical entity"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000006","label":"material anatomical entity"},{"@id":"http://purl.obolibrary.org/obo/CARO_0010000","label":"multicellular anatomical structure"},{"@id":"http://purl.obolibrary.org/obo/RO_0002577","label":"system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0000468","label":"multicellular organism"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0005884","label":"hyoid arch skeleton"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0008895","label":"splanchnocranium"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0010323","label":"cranial skeletal system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0010912","label":"subdivision of skeleton"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0011153","label":"ventral hyoid arch skeleton"},{"@id":"http://purl.obolibrary.org/obo/CARO_0000011","label":"connected anatomical system"},{"@id":"http://purl.obolibrary.org/obo/CARO_0030000","label":"biological entity"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0000061","label":"anatomical structure"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0000465","label":"material anatomical entity"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0000467","label":"anatomical system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0001062","label":"anatomical entity"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0010000","label":"multicellular anatomical structure"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0010314","label":"structure with developmental contribution from neural crest"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0001434","label":"skeletal system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0002204","label":"musculoskeletal system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0004288","label":"skeleton"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0000075","label":"subdivision of skeletal system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0011137","label":"axial skeletal system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0011159","label":"primary subdivision of cranial skeletal system"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0011216","label":"organ system subdivision"},{"@id":"http://purl.obolibrary.org/obo/UBERON_0034925","label":"anatomical collection"}]}

@Shalsh23 Shalsh23 marked this pull request as ready for review February 18, 2021 16:31
@Shalsh23 Shalsh23 requested a review from balhoff February 18, 2021 16:32
@Shalsh23 Shalsh23 requested a review from balhoff February 22, 2021 19:12
@balhoff balhoff merged commit 560446a into relations-graphs-updates Feb 22, 2021
@balhoff balhoff deleted the term-property-neighbors-subject branch February 22, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants