Adds quality_opposites parameter to mutually_exclusive() #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbradley
force-pushed
the
240-opposite-qualities
branch
4 times, most recently
from
cea86c0 to
cd0bb14
Compare
hlapp
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Looks good. I made a few minor changes to the parameter documentation. One thing I'm wondering is whether we couldn't put a few IRI pairs into a CSV in the examples directory, read that in as part of the example 4 and then simply rerun the same thing as in the previous example as a contrast. But we can make that a separate issue, with perhaps lower priority than this one.
|
I created issue #271 to improve the example. |
|
@hlapp Should I combine these two commits into one before merging into master? |
Yes that's fine! |
Adds an optional quality_opposites parameter to mutually_exclusive(). This parameter requires a dataframe with "quality.a" and "quality.b" columns that contain opposite IRIs. Fixes #240 Co-authored-by: Hilmar Lapp <hlapp@drycafe.net>
johnbradley
force-pushed
the
240-opposite-qualities
branch
from
64e460a to
3159d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional quality_opposites parameter to mutually_exclusive().
This parameter requires a dataframe with "quality.a" and "quality.b" columns that contain opposite IRIs.
Fixes #240