Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toaster component styles #20

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Fix toaster component styles #20

merged 1 commit into from
Mar 30, 2024

Conversation

Hyuuh
Copy link
Collaborator

@Hyuuh Hyuuh commented Mar 30, 2024

When you select the 'System' theme, that is, the system theme, the Toast did not understand the colors it should modify (77da8c4) and displayed in the light theme, even if your system is in dark mode. This is solved by modifying the Toast design with TailwindCSS

Note

The error is practically visible when you have dark mode enabled on your system and choose the 'system' theme.

Currently it looks like this System theme when you have dark mode enabled
msedge_PM94Ajzwop

As it appears in the light theme, there is no error in this theme
msedge_OoULFGF3sB

Now you can see how it's fixed in both themes.
msedge_BZzhvQoPv8
msedge_sC8AuEVhqe

@Hyuuh Hyuuh self-assigned this Mar 30, 2024
Copy link

vercel bot commented Mar 30, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @pheralb on Vercel.

@pheralb first needs to authorize it.

@Hyuuh Hyuuh removed their assignment Mar 30, 2024
@pheralb
Copy link
Owner

pheralb commented Mar 30, 2024

Thanks 🥹🚀

@pheralb pheralb merged commit b425248 into pheralb:main Mar 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants