Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve function hover #102

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

PgBiel
Copy link
Contributor

@PgBiel PgBiel commented Jan 25, 2025

Adds the fn keyword before function hover info to ensure proper syntax highlighting.

It's possible there are other places where this change would be appropriate, but this was the only one where the status quo appeared to actually break syntax highlighting.

Before PR:
function hover syntax highlighting is broken on Zed
function hover syntax highlighting is fine but not the best on VSCode

After PR:
function hover syntax highlighting fully functional
function hover syntax highlighting fully functional

@pherrymason pherrymason merged commit fbb737d into pherrymason:main Jan 25, 2025
2 checks passed
@PgBiel PgBiel deleted the slight-fn-hover-improvement branch January 25, 2025 18:53
@PgBiel
Copy link
Contributor Author

PgBiel commented Jan 25, 2025

Found out macros broke with #99; making a new PR.

Edit: Actually it's an old bug, but opening it anyway

@PgBiel PgBiel mentioned this pull request Jan 26, 2025
@pherrymason pherrymason mentioned this pull request Jan 28, 2025
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants