Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of non-type alias def #105

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Fix parsing of non-type alias def #105

merged 1 commit into from
Jan 26, 2025

Conversation

PgBiel
Copy link
Contributor

@PgBiel PgBiel commented Jan 26, 2025

Before PR: (yes, that's what would be inserted, including the = funcname part)

(Zed) completion suggests writing "replacement = takesA" instead of just "replacement"
(VSCode) completion suggests writing "replacement = takesA" instead of just "replacement"

After PR:

(Zed) completion suggests writing just "replacement"
(VSCode) completion suggests writing just "replacement"

@pherrymason
Copy link
Owner

Good catch! I'm impressed by how much this improved without even touching the search

@pherrymason pherrymason merged commit 904e095 into pherrymason:main Jan 26, 2025
2 checks passed
@PgBiel PgBiel deleted the def-non-type-alias branch January 26, 2025 06:57
@pherrymason pherrymason mentioned this pull request Jan 28, 2025
Draft
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PgBiel @pherrymason