Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use AquaRadioButtonGroup #245

Closed
3 tasks done
pixelzoom opened this issue Feb 20, 2020 · 1 comment
Closed
3 tasks done

use AquaRadioButtonGroup #245

pixelzoom opened this issue Feb 20, 2020 · 1 comment
Assignees
@pixelzoom
Labels
dev:phet-io

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 20, 2020 •
edited
Loading

From phetsims/sun#555, convert this sim to use AquaRadioButtonGroup for phet-io.

Use in place of AquaRadioButton in these places:

  • SoluteFormNode, we'll have to drop the vertical separator here.

screenshot_140

  • ATDetectorNode

screenshot_138

  • WavelengthControl

screenshot_139
@pixelzoom pixelzoom self-assigned this Feb 20, 2020
@pixelzoom pixelzoom mentioned this issue Feb 20, 2020
Open
25 tasks
@pixelzoom pixelzoom assigned pixelzoom and unassigned pixelzoom Feb 20, 2020
pixelzoom added a commit that referenced this issue Feb 26, 2020
@pixelzoom
use AquaRadioButtonGroup in ATDetectorNode, #245
9cfc424
pixelzoom added a commit that referenced this issue Feb 26, 2020
@pixelzoom
use AquaRadioButtonGroup in WavelengthControls, #245
3a4f15b
pixelzoom added a commit that referenced this issue Feb 26, 2020
@pixelzoom
convert SoluteFormNode to class, #245
5d5798d
pixelzoom added a commit that referenced this issue Feb 26, 2020
@pixelzoom
rename SoluteFormRadioButtonGroup, #245
20fee4d
pixelzoom added a commit that referenced this issue Feb 26, 2020
@pixelzoom
use AquaRadioButtonGroup in SoluteFormRadioButtonGroup, #245
4b80850
pixelzoom added a commit that referenced this issue Feb 26, 2020
@pixelzoom
factor out RADIO_BUTTON_TEXT_OPTIONS, #245
ada1f60
@pixelzoom
Copy link
Contributor Author

Work has been completed in the above commits. PhET-iO API was updates and tested in Studio.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom