-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wishlist of common components to add to lookup #27
Comments
Review comments and questions here:
|
@zepumph I'm not sure that a general Slider is the most helpful, since it's a fairly ubiquitous UI component. I think it's probably more helpful to distinguish between HSlider and VSlider, because a designer is likely looking for a more specific example. |
what about the use of Slider in NumberControl? Right now there is no way that would be differentiated. |
My wishlist included an entry for scenery-phet/NumberControl and scenery-phet/SpectrumSlider, so I don't think we'd be leaving any slider-like things out in the cold. I wouldn't oppose having a catch-all Slider entry, but it doesn't seem like the most useful component filter by. |
All of the above have been added, and Slider was removed. Perhaps Slider should actually be readed since there is a Slider.md No matter, here is the updated binder doc: http://phettest.colorado.edu/binder/doc/ What do you think? |
We have an A11y implementation pattern for Time Control now (see MAL). Should we have time to document this pattern, what repo would it go in? Should it go in scenery-phet? Adding there are nice shortcuts for toggling between Pause & Play and for Stepping Forward when Paused. |
We also have a new A11y Design pattern for the On/Off switch for MAL that would benefit from some documentation. Would an issue for the On/Off switch go in the sun repo? |
The On off switch for MAL is a
|
Please ignore phetsims/ratio-and-proportion@f88aabb, it was an incorrect git commit message. |
Binder is not currently a priority, so unassigning myself. |
…binder#27 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
In reviewing #25 I realized that there are many common UI components which are missing from the components-by-sim and sim-by-components lists in binder. Currently, it looks like the only components included are the ones which have associated .md files in the style guide.
I took a look around
sun
andscenery-phet
and I've come up with a preliminary wishlist.A few caveats:
scenery-phet
tend to have specific purposes (e.g.PlayPauseButton
) and I think it would be useful to be able to look up these sorts of buttons.The text was updated successfully, but these errors were encountered: