Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo-should-have-issues should support when // TODO and // {{ISSUE}} are on two different lines #1403

Closed
zepumph opened this issue Sep 15, 2023 · 1 comment
Closed

todo-should-have-issues should support when // TODO and // {{ISSUE}} are on two different lines #1403

zepumph opened this issue Sep 15, 2023 · 1 comment
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Sep 15, 2023

Reported in phetsims/tasks#1129 (comment) by @pixelzoom, and tagging phetsims/tasks#1128. Since this lint rule is being used in more spots, it deserves to be that much better.
@zepumph zepumph self-assigned this Sep 15, 2023
@zepumph zepumph mentioned this issue Sep 15, 2023
Closed
zepumph added a commit to phetsims/faradays-law that referenced this issue Sep 21, 2023
@zepumph
support TODOs + github issues spanning multiple line comments, phetsi…
7f23a06 
…ms/chipper#1403
@zepumph
Copy link
Member Author

zepumph commented Sep 21, 2023

I got this working and it is great. I noticed though that all usages of this strategy were reverted in phetsims/tasks#1129 by @pixelzoom. I reverted one of those cases to make sure this change was being exercised. Closing

zepumph added a commit to phetsims/area-model-common that referenced this issue Sep 21, 2023
@zepumph
support TODOs + github issues spanning multiple line comments, phetsi…
bd517dd 
…ms/chipper#1403
@zepumph zepumph closed this as completed Sep 21, 2023
zepumph added a commit that referenced this issue Sep 21, 2023
@zepumph
support TODOs + github issues spanning multiple line comments, #1403
430bdd5
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
support TODOs + github issues spanning multiple line comments, phetsi…
23e98c6 
…ms/chipper#1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph