Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviationsNode name #63

Closed
jonathanolson opened this issue Aug 13, 2015 · 2 comments
Closed

DeviationsNode name #63

jonathanolson opened this issue Aug 13, 2015 · 2 comments
Assignees
@jonathanolson
Labels
dev:code-review

Comments

@jonathanolson
Copy link
Contributor

Typically if it's a Panel used as a control panel, we'd call it "DeviationsPanel". "DeviationsNode"'s name let me to think it was displaying residuals.

Review: #31
andrey-zelenkov added a commit that referenced this issue Aug 30, 2015
@andrey-zelenkov
#63 DeviationsNode renamed into DeviationsPanel
7dba124
andrey-zelenkov added a commit that referenced this issue Aug 30, 2015
@andrey-zelenkov
#63 renamed file DeviationsNode.js into DeviationsPanel.js
df16588
@andrey-zelenkov
Copy link
Contributor

DeviationsNode renamed into DeviationsPanel. Reassign to @jonathanolson for verification.

@jonathanolson
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @andrey-zelenkov