Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable fit sliders have overlapping touch areas #72

Closed
jonathanolson opened this issue Aug 13, 2015 · 8 comments
Closed

Adjustable fit sliders have overlapping touch areas #72

jonathanolson opened this issue Aug 13, 2015 · 8 comments

Comments

@jonathanolson
Copy link
Contributor

Can the touch areas be slightly less wide so that they are flush?

Review: #31

@andrey-zelenkov
Copy link
Contributor

I'm using SUN/HSlider to draw slider and I can't find any option to change touch areas of default thumb. Also I can't find default ThumbNode module to pass it using thumbNode option. Should all code related to ThumbNode be copied form HSlider to adjustable sliders class? Or there other way to change size of touch areas?

@jonathanolson
Copy link
Contributor Author

Removing 'review' label, I'll take care of this one. Will ask in developer meeting about standard ways of handling touch areas for this.

@jonathanolson
Copy link
Contributor Author

Plan to create default thumb, change touch areas, and pass it through as a custom thumb.

@jonathanolson
Copy link
Contributor Author

Or... just provide public access to the thumb. Probably that.

@jonathanolson
Copy link
Contributor Author

Decided on dot.Insets, and integration with bounds modifiers. Add thumbMouseAreaInsets and thumbTouchAreaInsets as options, that will only modify the default behavior.

@Denz1994
Copy link
Contributor

Denz1994 commented Jul 7, 2016

Adjusted slider touch area parameters by changing the HSlider options. Made possible by phetsims/sun@c5dbf7c

@pixelzoom
Copy link
Contributor

I will review this as part of a more general test of pointer areas.

@SaurabhTotey
Copy link
Member

Touch areas are now flush for adjustable fit sliders.

Slider Touch Areas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants