-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustable fit sliders have overlapping touch areas #72
Comments
I'm using SUN/HSlider to draw slider and I can't find any option to change touch areas of default thumb. Also I can't find default ThumbNode module to pass it using thumbNode option. Should all code related to ThumbNode be copied form HSlider to adjustable sliders class? Or there other way to change size of touch areas? |
Removing 'review' label, I'll take care of this one. Will ask in developer meeting about standard ways of handling touch areas for this. |
Plan to create default thumb, change touch areas, and pass it through as a custom thumb. |
Or... just provide public access to the thumb. Probably that. |
Decided on dot.Insets, and integration with bounds modifiers. Add thumbMouseAreaInsets and thumbTouchAreaInsets as options, that will only modify the default behavior. |
Adjusted slider touch area parameters by changing the HSlider options. Made possible by phetsims/sun@c5dbf7c |
I will review this as part of a more general test of pointer areas. |
Can the touch areas be slightly less wide so that they are flush?
Review: #31
The text was updated successfully, but these errors were encountered: