We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During #5, I noticed some duplicated magic numbers in Cone:
/** * Returns the radius from a general size scale * @public * @override * * @param {number} widthRatio * @returns {number} */ static getRadiusFromRatio( widthRatio ) { return 0.01 + widthRatio * 0.09; } /** * Returns the height from a general size scale * @public * @override * * @param {number} heightRatio * @returns {number} */ static getHeightFromRatio( heightRatio ) { return 2 * ( 0.01 + heightRatio * 0.09 ); }
I also see a lot of 0.75 and 0.25 in this file. Should some of these constants be factored out and described?
The text was updated successfully, but these errors were encountered:
Reducing cone duplication, see #10
ca07639
The getRadiusFromRatio and getHeightFromRatio are not tied together, just happen to be similar. Otherwise I factored out constants. Can you review?
Sorry, something went wrong.
Looks good, thanks! Closing.
samreid
No branches or pull requests
During #5, I noticed some duplicated magic numbers in Cone:
I also see a lot of 0.75 and 0.25 in this file. Should some of these constants be factored out and described?
The text was updated successfully, but these errors were encountered: