-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard help dialog needed #102
Comments
@DianaTavares. I believe the first step here is to make a design. This is because it has custom dragging that likely wants sim-specific wording. For examples you can poke the all our keyboard help dialogs here: https://phetsims.github.io/binder/#joist-KeyboardHelpDialog |
@zepumph, that is an amazing link! Thanks for posting it in this issue. @DianaTavares here are some KBS dialog exmaples that cover draggable objects, sliders, and comboboxes |
It's trivial to change the heading content to be more sim specific. There are other customizations that can be made if they are really important for the interaction or for the organization of the dialog content. For example, is GFL:B and GFL regular, the Move Spheres and Change Mass sections were reduced to just one set of arrow keys even though all the 4 arrow keys work. Doing this emphasizes the orientation of the interaction in GFL:B, and de-clutter the instructions for both sims. De-cluttering was essential for GFL regular because the instructions for grabbing and moving the Ruler are long. |
Some Tips:
|
Thanks for all your support @terracoda!! Buoyancy is super general. Then I use the general picture that @terracoda share and delete the information that is not going to b needed in each screen, this is the information: |
@jessegreenberg, I am not sure if "Pop Up Menu" is the final heading for the latest version of combobox. Can you double check that. We just updated the common code combobox info for Gas Properties and I can't remember if "Pop Up Menu" was the final text for the heading. |
Yes, "Pop Up Menu" was the choice from phetsims/scenery-phet#852. |
Thanks for posting the issue number. In this comment, phetsims/scenery-phet#852 (comment) I had suggested "Show Choices" or "Pop Open Menu", since the menu doesn't always go up. And sorry, I am not sure what I am supposed to review in phetsims/scenery-phet/issues/852 |
Ah, I think just to confirm you like the final language for default content. If you want it to change to "Show Choices", can you please comment over there? |
Over in the other issue, I made the default to "Change X" or "Change Choice". That captures the spirit of the heading language better, since "Show Choices" is step 1. |
@terracoda and I reviewed the implementation and it seems good to close. @terracoda indicated we could change the headings to say e.g., "drag blocks" or things that are more screen-specific, but we discussed that that is non-trivial and could take >1hr to do for all 10 screens across 3 sims. So we are OK to close. |
From #98 and phetsims/buoyancy#76. This should have probably been done over there.
The text was updated successfully, but these errors were encountered: