Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the red line in the debug view? #18

Closed
samreid opened this issue Aug 9, 2021 · 5 comments
Closed

What is the red line in the debug view? #18

samreid opened this issue Aug 9, 2021 · 5 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Aug 9, 2021

I tested the debug view and saw a red line I didn't understand, is this how it should behave? For #5

image

@samreid
Copy link
Member Author

samreid commented Aug 9, 2021

Also, there is a green line.

@jonathanolson
Copy link
Contributor

It's essentially a sideways chart, with:

  • green proportional to the volume up to that level that is displaced in that basin
  • red proportional to the area at that level that is displaced in that basin

So it shows essentially the "how much stuff isn't liquid" and the integral of that. These are incredibly helpful for debugging algorithms that use these (where should the liquid level be for basins), but also for if they are buggy (I had a few integral ones wrong earlier).

@samreid
Copy link
Member Author

samreid commented Aug 11, 2021

Sounds good, can you please add notes of that nature to the implementation?

@samreid samreid assigned jonathanolson and unassigned samreid Aug 11, 2021
jonathanolson added a commit that referenced this issue Aug 12, 2021
@jonathanolson
Copy link
Contributor

Added notes above.

@samreid
Copy link
Member Author

samreid commented Aug 12, 2021

Excellent, thanks! Closing.

@samreid samreid closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants