You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following standard GitHub issues should exist. If these issues are missing, or have not been completed, pause code review until the issues have been created and addressed by the responsible dev.
results of memory testing for brands=phet, see {{GITHUB_ISSUE_LINK}}
results of memory testing for brands=phet-io (if the sim is instrumented for PhET-iO), see {{GITHUB_ISSUE_LINK}}
performance testing and sign-off, see {{GITHUB_ISSUE_LINK}}
review of pointer areas, see {{GITHUB_ISSUE_LINK}}
credits (will not be completed until after RC testing), see {{GITHUB_ISSUE_LINK}}
and
Does a heap comparison using Chrome Developer Tools indicate a memory leak? (Describing this process is beyond the scope of this document.) Test on a version built using grunt --minify.mangle=false. Compare to testing results done by the responsible developer. Results can be found in {{GITHUB_ISSUE_LINK}}.
I didn't see issues like this in the density-buoyancy-common repo, @jonathanolson can you please advise?
The text was updated successfully, but these errors were encountered:
From #5, I noticed it said:
The following standard GitHub issues should exist. If these issues are missing, or have not been completed, pause code review until the issues have been created and addressed by the responsible dev.
brands=phet
, see {{GITHUB_ISSUE_LINK}}brands=phet-io
(if the sim is instrumented for PhET-iO), see {{GITHUB_ISSUE_LINK}}and
grunt --minify.mangle=false
. Compare to testing results done by the responsible developer. Results can be found in {{GITHUB_ISSUE_LINK}}.I didn't see issues like this in the density-buoyancy-common repo, @jonathanolson can you please advise?
The text was updated successfully, but these errors were encountered: