Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there issues for the {{GITHUB_ISSUE_LINK}} in the code review? #24

Closed
6 tasks
samreid opened this issue Aug 9, 2021 · 4 comments
Closed
6 tasks
Assignees

Comments

@samreid
Copy link
Member

samreid commented Aug 9, 2021

From #5, I noticed it said:

The following standard GitHub issues should exist. If these issues are missing, or have not been completed, pause code review until the issues have been created and addressed by the responsible dev.

  • results of memory testing for brands=phet, see {{GITHUB_ISSUE_LINK}}
  • results of memory testing for brands=phet-io (if the sim is instrumented for PhET-iO), see {{GITHUB_ISSUE_LINK}}
  • performance testing and sign-off, see {{GITHUB_ISSUE_LINK}}
  • review of pointer areas, see {{GITHUB_ISSUE_LINK}}
  • credits (will not be completed until after RC testing), see {{GITHUB_ISSUE_LINK}}

and

  • Does a heap comparison using Chrome Developer Tools indicate a memory leak? (Describing this process is beyond the scope of this document.) Test on a version built using grunt --minify.mangle=false. Compare to testing results done by the responsible developer. Results can be found in {{GITHUB_ISSUE_LINK}}.

I didn't see issues like this in the density-buoyancy-common repo, @jonathanolson can you please advise?

@jonathanolson
Copy link
Contributor

phetsims/density#70 is the dedicated performance issue.

@jonathanolson
Copy link
Contributor

Credits issue is phetsims/density#31.

@jonathanolson
Copy link
Contributor

Added the above issues (or mentioned existing ones), and I'll handle the memory testing again. Does that look sufficient?

@samreid
Copy link
Member Author

samreid commented Aug 12, 2021

The side issues look great, thanks! Closing.

@samreid samreid closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants