-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sim Credits #31
Comments
I added the lead design, developer, and team credits in the above commit. I credited HTML5 and legacy team members, as conventional, see phetsims/joist#716 |
It doesn't look like the QA credits were confirmed in RC. @KatieWoe does this look correct? |
Yes, that is correct. I messaged them to JO |
Thanks @KatieWoe. I see a few other testers opened issues in phetsims/qa#507, but weren't credited. (To be fair, it's a really old dev test.) @jonathanolson I recommend you add Jacob Romero, Logan Bray, Liam Mulhall, and Steele Dalton to the QA credits. |
Committed to master and 1.0. @arouinfar does the change above look correct? |
@jonathanolson the names all look correct, but the convention is to alphabetize them. Sorry I didn't catch that earlier. The correct order would be: Not sure if it's better to revert and re-commit or just make another commit, so I'll leave it up to @jonathanolson to fix. |
Credits fixed up above, can you verify? |
Looks good! |
For phetsims/qa#507 there are no credits when you open the about menu. There is a credits title but as you can see from the screenshot below there are no credits at all. Everything else in the about menu seems to be fine. I'm not sure if this is the right tag for things like this so let me know if there is a more appropriate tag for similar issues in the future.

The text was updated successfully, but these errors were encountered: