Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim Credits #31

Closed
JRomero0613 opened this issue Jun 16, 2020 · 8 comments
Closed

Sim Credits #31

JRomero0613 opened this issue Jun 16, 2020 · 8 comments

Comments

@JRomero0613
Copy link

JRomero0613 commented Jun 16, 2020

For phetsims/qa#507 there are no credits when you open the about menu. There is a credits title but as you can see from the screenshot below there are no credits at all. Everything else in the about menu seems to be fine. I'm not sure if this is the right tag for things like this so let me know if there is a more appropriate tag for similar issues in the future.
Density_Credits

@jonathanolson jonathanolson removed their assignment Aug 5, 2020
@arouinfar arouinfar changed the title No Credits Sim Credits Jul 22, 2021
@arouinfar
Copy link
Contributor

I added the lead design, developer, and team credits in the above commit. I credited HTML5 and legacy team members, as conventional, see phetsims/joist#716

@arouinfar
Copy link
Contributor

It doesn't look like the QA credits were confirmed in RC. @KatieWoe does this look correct?

image

@KatieWoe
Copy link
Contributor

Yes, that is correct. I messaged them to JO

@arouinfar
Copy link
Contributor

Thanks @KatieWoe. I see a few other testers opened issues in phetsims/qa#507, but weren't credited. (To be fair, it's a really old dev test.)

@jonathanolson I recommend you add Jacob Romero, Logan Bray, Liam Mulhall, and Steele Dalton to the QA credits.

@arouinfar arouinfar assigned jonathanolson and unassigned arouinfar and KatieWoe Jan 11, 2022
jonathanolson added a commit that referenced this issue Jan 11, 2022
jonathanolson added a commit that referenced this issue Jan 11, 2022
@jonathanolson
Copy link
Contributor

Committed to master and 1.0. @arouinfar does the change above look correct?

@arouinfar
Copy link
Contributor

@jonathanolson the names all look correct, but the convention is to alphabetize them. Sorry I didn't catch that earlier.

The correct order would be:
Logan Bray, Steele Dalton, Brooklyn Lash, Emily Miller, Liam Mulhall, Devon Quispe, Jacob Romero, Nancy Salpepi, Katie Woessner

Not sure if it's better to revert and re-commit or just make another commit, so I'll leave it up to @jonathanolson to fix.

@arouinfar arouinfar assigned jonathanolson and unassigned arouinfar Jan 12, 2022
jonathanolson added a commit that referenced this issue Jan 12, 2022
jonathanolson added a commit that referenced this issue Jan 12, 2022
@jonathanolson
Copy link
Contributor

Credits fixed up above, can you verify?

@arouinfar
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants