Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boat.getBasinArea is marked as @override but not clear what it overrrides #29

Closed
samreid opened this issue Aug 10, 2021 · 2 comments
Closed
Assignees

Comments

@samreid
Copy link
Member

samreid commented Aug 10, 2021

In #5, I observed Boat.getBasinArea is marked as @override but not clear what it overrrides.

  /**
   * Returns the internal basin area of this object up to a given y level, assuming a y value for the given liquid level.
   * @public
   * @override
   *
   * Assumes step information was updated.
   *
   * @param {number} liquidLevel
   * @returns {number}
   */
  getBasinArea( liquidLevel ) {
    const bottom = this.stepBottom;
    const top = this.stepTop;

I don't see any declarations of getBasinArea to override. @jonathanolson can you take a look?

@jonathanolson
Copy link
Contributor

Thanks for the catch, definitely had the wrong doc.

@samreid
Copy link
Member Author

samreid commented Aug 10, 2021

Looks good, thanks! Closing.

@samreid samreid closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants