Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does package.json refer to any dependencies that are not used by the sim? #44

Closed
Tracked by #5
samreid opened this issue Aug 11, 2021 · 2 comments
Closed
Tracked by #5
Assignees

Comments

@samreid
Copy link
Member

samreid commented Aug 11, 2021

For #5, I noticed that density-buoyancy-common and density have different preloads. Density lists "../sherpa/lib/poly-decomp-0.3.0.js", but density-buoyancy-common does not. Also, I forget if preloads are transitive or have to be mentioned in each file.

@jonathanolson
Copy link
Contributor

It's not transitive, I could probably toss the density-buoyancy-common dependencies. For me it's helpful documentation, but I'm curious what your thoughts are. I updated it above, but should we just get rid of them?

@samreid
Copy link
Member Author

samreid commented Aug 11, 2021

I would keep them for clarity, keeping in mind one day density-buoyancy-common may have a test harness. The commit looks good, closing.

@samreid samreid closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants